|
| 17 Apr 2015 01:36 PM |
Hi, I am a owner of Liberty Lanes. I just need a bit of help with the lane bumpers which I have just installed. The problem with this script is that it is only reading 1 part instead of all of them.
This model has 92 parts, but the problem is that it is just only highlighting the 92nd part instead of the rest.
NOTE: Please see the before script aswell, as you know what's changed and etc...
Problem (which it is in part of the script): for i = 1, 92 do
Whole Script: local isOn = true for i = 92, 92 do function on() isOn = true script.Parent:FindFirstChild("lol"..i).Transparency = 1 script.Parent:FindFirstChild("lol"..i).CanCollide = false end
function off() isOn = false script.Parent:FindFirstChild("lol"..i).Transparency = 0 script.Parent:FindFirstChild("lol"..i).CanCollide = true end
function onClicked() if isOn == true then off() else on() end
end end
script.Parent.PosA1.ClickDetector.MouseClick:connect(onClicked) script.Parent.PosA2.ClickDetector.MouseClick:connect(onClicked)
on()
Before Script: local isOn = true
function on() isOn = true script.Parent.PosA1.Transparency = 0 script.Parent.PosA1.CanCollide = true script.Parent.PosA2.Transparency = 1 script.Parent.PosA2.CanCollide = false script.Parent.lol1.Transparency = 1 script.Parent.lol1.CanCollide = false script.Parent.lol2.Transparency = 1 script.Parent.lol2.CanCollide = false script.Parent.lol3.Transparency = 1 script.Parent.lol3.CanCollide = false script.Parent.lol4.Transparency = 1 script.Parent.lol4.CanCollide = false script.Parent.lol5.Transparency = 1 script.Parent.lol5.CanCollide = false script.Parent.lol6.Transparency = 1 script.Parent.lol6.CanCollide = false script.Parent.lol7.Transparency = 1 script.Parent.lol7.CanCollide = false script.Parent.lol8.Transparency = 1 script.Parent.lol8.CanCollide = false script.Parent.lol9.Transparency = 1 script.Parent.lol9.CanCollide = false script.Parent.lol10.Transparency = 1 script.Parent.lol10.CanCollide = false script.Parent.lol11.Transparency = 1 script.Parent.lol11.CanCollide = false script.Parent.lol12.Transparency = 1 script.Parent.lol12.CanCollide = false script.Parent.lol13.Transparency = 1 script.Parent.lol13.CanCollide = false script.Parent.lol14.Transparency = 1 script.Parent.lol14.CanCollide = false script.Parent.lol15.Transparency = 1 script.Parent.lol15.CanCollide = false script.Parent.lol16.Transparency = 1 script.Parent.lol16.CanCollide = false script.Parent.lol17.Transparency = 1 script.Parent.lol17.CanCollide = false script.Parent.lol18.Transparency = 1 script.Parent.lol18.CanCollide = false script.Parent.lol19.Transparency = 1 script.Parent.lol19.CanCollide = false script.Parent.lol20.Transparency = 1 script.Parent.lol20.CanCollide = false script.Parent.lol21.Transparency = 1 script.Parent.lol21.CanCollide = false script.Parent.lol22.Transparency = 1 script.Parent.lol22.CanCollide = false script.Parent.lol23.Transparency = 1 script.Parent.lol23.CanCollide = false script.Parent.lol24.Transparency = 1 script.Parent.lol24.CanCollide = false script.Parent.lol25.Transparency = 1 script.Parent.lol25.CanCollide = false script.Parent.lol26.Transparency = 1 script.Parent.lol26.CanCollide = false script.Parent.lol27.Transparency = 1 script.Parent.lol27.CanCollide = false script.Parent.lol28.Transparency = 1 script.Parent.lol28.CanCollide = false script.Parent.lol29.Transparency = 1 script.Parent.lol29.CanCollide = false script.Parent.lol30.Transparency = 1 script.Parent.lol30.CanCollide = false script.Parent.lol31.Transparency = 1 script.Parent.lol31.CanCollide = false script.Parent.lol32.Transparency = 1 script.Parent.lol32.CanCollide = false script.Parent.lol33.Transparency = 1 script.Parent.lol33.CanCollide = false script.Parent.lol34.Transparency = 1 script.Parent.lol34.CanCollide = false script.Parent.lol35.Transparency = 1 script.Parent.lol35.CanCollide = false script.Parent.lol36.Transparency = 1 script.Parent.lol36.CanCollide = false script.Parent.lol37.Transparency = 1 script.Parent.lol37.CanCollide = false script.Parent.lol38.Transparency = 1 script.Parent.lol38.CanCollide = false script.Parent.lol39.Transparency = 1 script.Parent.lol39.CanCollide = false script.Parent.lol40.Transparency = 1 script.Parent.lol40.CanCollide = false script.Parent.lol41.Transparency = 1 script.Parent.lol41.CanCollide = false script.Parent.lol42.Transparency = 1 script.Parent.lol42.CanCollide = false script.Parent.lol43.Transparency = 1 script.Parent.lol43.CanCollide = false script.Parent.lol44.Transparency = 1 script.Parent.lol44.CanCollide = false script.Parent.lol45.Transparency = 1 script.Parent.lol45.CanCollide = false script.Parent.lol46.Transparency = 1 script.Parent.lol46.CanCollide = false script.Parent.lol47.Transparency = 1 script.Parent.lol47.CanCollide = false script.Parent.lol48.Transparency = 1 script.Parent.lol48.CanCollide = false script.Parent.lol49.Transparency = 1 script.Parent.lol49.CanCollide = false script.Parent.lol50.Transparency = 1 script.Parent.lol50.CanCollide = false script.Parent.lol51.Transparency = 1 script.Parent.lol51.CanCollide = false script.Parent.lol52.Transparency = 1 script.Parent.lol52.CanCollide = false script.Parent.lol53.Transparency = 1 script.Parent.lol53.CanCollide = false script.Parent.lol54.Transparency = 1 script.Parent.lol54.CanCollide = false script.Parent.lol55.Transparency = 1 script.Parent.lol55.CanCollide = false script.Parent.lol56.Transparency = 1 script.Parent.lol56.CanCollide = false script.Parent.lol57.Transparency = 1 script.Parent.lol57.CanCollide = false script.Parent.lol58.Transparency = 1 script.Parent.lol58.CanCollide = false script.Parent.lol59.Transparency = 1 script.Parent.lol59.CanCollide = false script.Parent.lol60.Transparency = 1 script.Parent.lol60.CanCollide = false script.Parent.lol61.Transparency = 1 script.Parent.lol61.CanCollide = false script.Parent.lol62.Transparency = 1 script.Parent.lol62.CanCollide = false script.Parent.lol63.Transparency = 1 script.Parent.lol63.CanCollide = false script.Parent.lol64.Transparency = 1 script.Parent.lol64.CanCollide = false script.Parent.lol65.Transparency = 1 script.Parent.lol65.CanCollide = false script.Parent.lol66.Transparency = 1 script.Parent.lol66.CanCollide = false script.Parent.lol67.Transparency = 1 script.Parent.lol67.CanCollide = false script.Parent.lol68.Transparency = 1 script.Parent.lol68.CanCollide = false script.Parent.lol69.Transparency = 1 script.Parent.lol69.CanCollide = false script.Parent.lol70.Transparency = 1 script.Parent.lol70.CanCollide = false script.Parent.lol71.Transparency = 1 script.Parent.lol71.CanCollide = false script.Parent.lol72.Transparency = 1 script.Parent.lol72.CanCollide = false script.Parent.lol73.Transparency = 1 script.Parent.lol73.CanCollide = false script.Parent.lol74.Transparency = 1 script.Parent.lol74.CanCollide = false script.Parent.lol75.Transparency = 1 script.Parent.lol75.CanCollide = false script.Parent.lol76.Transparency = 1 script.Parent.lol76.CanCollide = false script.Parent.lol77.Transparency = 1 script.Parent.lol77.CanCollide = false script.Parent.lol78.Transparency = 1 script.Parent.lol78.CanCollide = false end
function off() isOn = false script.Parent.PosA1.Transparency = 1 script.Parent.PosA1.CanCollide = false script.Parent.PosA2.Transparency = 0 script.Parent.PosA2.CanCollide = true script.Parent.lol1.Transparency = 0 script.Parent.lol1.CanCollide = true script.Parent.lol2.Transparency = 0 script.Parent.lol2.CanCollide = true script.Parent.lol3.Transparency = 0 script.Parent.lol3.CanCollide = true script.Parent.lol4.Transparency = 0 script.Parent.lol4.CanCollide = true script.Parent.lol5.Transparency = 0 script.Parent.lol5.CanCollide = true script.Parent.lol6.Transparency = 0 script.Parent.lol6.CanCollide = true script.Parent.lol7.Transparency = 0 script.Parent.lol7.CanCollide = true script.Parent.lol8.Transparency = 0 script.Parent.lol8.CanCollide = true script.Parent.lol9.Transparency = 0 script.Parent.lol9.CanCollide = true script.Parent.lol10.Transparency = 0 script.Parent.lol10.CanCollide = true script.Parent.lol11.Transparency = 0 script.Parent.lol11.CanCollide = true script.Parent.lol12.Transparency = 0 script.Parent.lol12.CanCollide = true script.Parent.lol13.Transparency = 0 script.Parent.lol13.CanCollide = true script.Parent.lol14.Transparency = 0 script.Parent.lol14.CanCollide = true script.Parent.lol15.Transparency = 0 script.Parent.lol15.CanCollide = true script.Parent.lol16.Transparency = 0 script.Parent.lol16.CanCollide = true script.Parent.lol17.Transparency = 0 script.Parent.lol17.CanCollide = true script.Parent.lol18.Transparency = 0 script.Parent.lol18.CanCollide = true script.Parent.lol19.Transparency = 0 script.Parent.lol19.CanCollide = true script.Parent.lol20.Transparency = 0 script.Parent.lol20.CanCollide = true script.Parent.lol21.Transparency = 0 script.Parent.lol21.CanCollide = true script.Parent.lol22.Transparency = 0 script.Parent.lol22.CanCollide = true script.Parent.lol23.Transparency = 0 script.Parent.lol23.CanCollide = true script.Parent.lol24.Transparency = 0 script.Parent.lol24.CanCollide = true script.Parent.lol25.Transparency = 0 script.Parent.lol25.CanCollide = true script.Parent.lol26.Transparency = 0 script.Parent.lol26.CanCollide = true script.Parent.lol27.Transparency = 0 script.Parent.lol27.CanCollide = true script.Parent.lol28.Transparency = 0 script.Parent.lol28.CanCollide = true script.Parent.lol29.Transparency = 0 script.Parent.lol29.CanCollide = true script.Parent.lol30.Transparency = 0 script.Parent.lol30.CanCollide = true script.Parent.lol31.Transparency = 0 script.Parent.lol31.CanCollide = true script.Parent.lol32.Transparency = 0 script.Parent.lol32.CanCollide = true script.Parent.lol33.Transparency = 0 script.Parent.lol33.CanCollide = true script.Parent.lol34.Transparency = 0 script.Parent.lol34.CanCollide = true script.Parent.lol35.Transparency = 0 script.Parent.lol35.CanCollide = true script.Parent.lol36.Transparency = 0 script.Parent.lol36.CanCollide = true script.Parent.lol37.Transparency = 0 script.Parent.lol37.CanCollide = true script.Parent.lol38.Transparency = 0 script.Parent.lol38.CanCollide = true script.Parent.lol39.Transparency = 0 script.Parent.lol39.CanCollide = true script.Parent.lol40.Transparency = 0 script.Parent.lol40.CanCollide = true script.Parent.lol41.Transparency = 0 script.Parent.lol41.CanCollide = true script.Parent.lol42.Transparency = 0 script.Parent.lol42.CanCollide = true script.Parent.lol43.Transparency = 0 script.Parent.lol43.CanCollide = true script.Parent.lol44.Transparency = 0 script.Parent.lol44.CanCollide = true script.Parent.lol45.Transparency = 0 script.Parent.lol45.CanCollide = true script.Parent.lol46.Transparency = 0 script.Parent.lol46.CanCollide = true script.Parent.lol47.Transparency = 0 script.Parent.lol47.CanCollide = true script.Parent.lol48.Transparency = 0 script.Parent.lol48.CanCollide = true script.Parent.lol49.Transparency = 0 script.Parent.lol49.CanCollide = true script.Parent.lol50.Transparency = 0 script.Parent.lol50.CanCollide = true script.Parent.lol51.Transparency = 0 script.Parent.lol51.CanCollide = true script.Parent.lol52.Transparency = 0 script.Parent.lol52.CanCollide = true script.Parent.lol53.Transparency = 0 script.Parent.lol53.CanCollide = true script.Parent.lol54.Transparency = 0 script.Parent.lol54.CanCollide = true script.Parent.lol55.Transparency = 0 script.Parent.lol55.CanCollide = true script.Parent.lol56.Transparency = 0 script.Parent.lol56.CanCollide = true script.Parent.lol57.Transparency = 0 script.Parent.lol57.CanCollide = true script.Parent.lol58.Transparency = 0 script.Parent.lol58.CanCollide = true script.Parent.lol59.Transparency = 0 script.Parent.lol59.CanCollide = true script.Parent.lol60.Transparency = 0 script.Parent.lol60.CanCollide = true script.Parent.lol61.Transparency = 0 script.Parent.lol61.CanCollide = true script.Parent.lol62.Transparency = 0 script.Parent.lol62.CanCollide = true script.Parent.lol63.Transparency = 0 script.Parent.lol63.CanCollide = true script.Parent.lol64.Transparency = 0 script.Parent.lol64.CanCollide = true script.Parent.lol65.Transparency = 0 script.Parent.lol65.CanCollide = true script.Parent.lol66.Transparency = 0 script.Parent.lol66.CanCollide = true script.Parent.lol67.Transparency = 0 script.Parent.lol67.CanCollide = true script.Parent.lol68.Transparency = 0 script.Parent.lol68.CanCollide = true script.Parent.lol69.Transparency = 0 script.Parent.lol69.CanCollide = true script.Parent.lol70.Transparency = 0 script.Parent.lol70.CanCollide = true script.Parent.lol71.Transparency = 0 script.Parent.lol71.CanCollide = true script.Parent.lol72.Transparency = 0 script.Parent.lol72.CanCollide = true script.Parent.lol73.Transparency = 0 script.Parent.lol73.CanCollide = true script.Parent.lol74.Transparency = 0 script.Parent.lol74.CanCollide = true script.Parent.lol75.Transparency = 0 script.Parent.lol75.CanCollide = true script.Parent.lol76.Transparency = 0 script.Parent.lol76.CanCollide = true script.Parent.lol77.Transparency = 0 script.Parent.lol77.CanCollide = true script.Parent.lol78.Transparency = 0 script.Parent.lol78.CanCollide = true end
function onClicked() if isOn == true then off() else on() end
end
script.Parent.PosA1.ClickDetector.MouseClick:connect(onClicked) script.Parent.PosA2.ClickDetector.MouseClick:connect(onClicked)
on()
_______________
Thank you!
BloxianBoy1234 CEO of Liberty Lanes |
|
|
| Report Abuse |
|
|
|
| 17 Apr 2015 01:38 PM |
| Try the in pairs loop instead of the for i = 1 loop |
|
|
| Report Abuse |
|
|
| |
|
|
| 17 Apr 2015 01:46 PM |
nub = script.Parent:FindFirstChild(lol):GetChildren() -- Assuming that lol is a model and everything is inside lol.
for i,v in pairs (lol) do --Remember that i is the thing that makes it go through every item in the model lol, and v is the actual item function on() isOn = true v.Transparency = 1 v.CanCollide = false end
I think its like that for the first part |
|
|
| Report Abuse |
|
|
|
| 17 Apr 2015 02:12 PM |
sorry i made a mistake
nub = script.Parent:FindFirstChild(lol):GetChildren() -- Assuming that lol is a model and everything is inside lol.
for i,v in pairs (nub) do --Remember that i is the thing that makes it go through every item in the model lol, and v is the actual item function on() isOn = true v.Transparency = 1 v.CanCollide = false end |
|
|
| Report Abuse |
|
|
|
| 17 Apr 2015 02:13 PM |
and i think the problem with ur script is that when u put for i = 92, 92 you were suppose to put for i = 1, 92.
its always suppose to be 1 |
|
|
| Report Abuse |
|
|
|
| 17 Apr 2015 02:25 PM |
| The script doesn't work, the "lol" was wriggled in blue. I don't see a definition of nub in the script apart from the first line, so do I need to delete it or... |
|
|
| Report Abuse |
|
|
|
| 17 Apr 2015 02:26 PM |
| Oh sorry, too late. I could've refreshed the page for the latest update. I meant an error on the first script you've written. |
|
|
| Report Abuse |
|
|
|
| 17 Apr 2015 02:34 PM |
Still doesn't work. The "lol" is wiggled, but everything that you just changed with the script lately still doesn't work.
I've made a model called "lol" with all the lol(number) parts, but it still doesn't work.
Is there any other way? |
|
|
| Report Abuse |
|
|
| |
|
NotAshley
|
  |
| Joined: 16 Jan 2014 |
| Total Posts: 14257 |
|
|
| 19 Apr 2015 12:29 AM |
| That's the longest eyesore I've ever seen. You should seriously look into iteration so you can edit the Transparency and CanCollide of everything at once instead of typing it all out. |
|
|
| Report Abuse |
|
|
cxcharlie
|
  |
| Joined: 26 Aug 2009 |
| Total Posts: 1414 |
|
| |
|
|
| 19 Apr 2015 03:34 PM |
| NotAshley, could you show me how you script it out? |
|
|
| Report Abuse |
|
|
NotAshley
|
  |
| Joined: 16 Jan 2014 |
| Total Posts: 14257 |
|
|
| 19 Apr 2015 03:46 PM |
This whole bit with all these lines:
script.Parent.lol1.Transparency = 1 script.Parent.lol1.CanCollide = false script.Parent.lol2.Transparency = 1 script.Parent.lol2.CanCollide = false script.Parent.lol3.Transparency = 1 script.Parent.lol3.CanCollide = false script.Parent.lol4.Transparency = 1 script.Parent.lol4.CanCollide = false script.Parent.lol5.Transparency = 1 script.Parent.lol5.CanCollide = false ... etc
Can be shortened to this:
for _,v in pairs(script.Parent:GetChildren()) do if string.sub(v.Name,1,3) == "lol" -- check if it's a 'lol' part v.Transparency = 1 v.CanCollide = false end end |
|
|
| Report Abuse |
|
|
|
| 19 Apr 2015 04:00 PM |
| Thank you, the script worked! Just a tiny problem is that you need to make so that when it get pressed again, it pops up. The opposite way! |
|
|
| Report Abuse |
|
|
NotAshley
|
  |
| Joined: 16 Jan 2014 |
| Total Posts: 14257 |
|
|
| 19 Apr 2015 04:05 PM |
Just use the same line but change the properties:
for _,v in pairs(script.Parent:GetChildren()) do if string.sub(v.Name,1,3) == "lol" v.Transparency = 0 v.CanCollide = true end end |
|
|
| Report Abuse |
|
|
NotAshley
|
  |
| Joined: 16 Jan 2014 |
| Total Posts: 14257 |
|
|
| 19 Apr 2015 04:07 PM |
Here's the whole script:
local isOn = true for i = 92, 92 do function on() isOn = true script.Parent:FindFirstChild("lol"..i).Transparency = 1 script.Parent:FindFirstChild("lol"..i).CanCollide = false end
function off() isOn = false script.Parent:FindFirstChild("lol"..i).Transparency = 0 script.Parent:FindFirstChild("lol"..i).CanCollide = true end
function onClicked() if isOn == true then off() else on() end
end end
script.Parent.PosA1.ClickDetector.MouseClick:connect(onClicked) script.Parent.PosA2.ClickDetector.MouseClick:connect(onClicked)
on()
Before Script: local isOn = true
function on() isOn = true isOn = false for _,v in pairs(script.Parent:GetChildren()) do if string.sub(v.Name,1,3) == "lol" then v.Transparency = 1 v.CanCollide = false end end end
function off() isOn = false for _,v in pairs(script.Parent:GetChildren()) do if string.sub(v.Name,1,3) == "lol" then v.Transparency = 0 v.CanCollide = true end end end
function onClicked() if isOn == true then off() else on() end
end
script.Parent.PosA1.ClickDetector.MouseClick:connect(onClicked) script.Parent.PosA2.ClickDetector.MouseClick:connect(onClicked)
on() |
|
|
| Report Abuse |
|
|
NotAshley
|
  |
| Joined: 16 Jan 2014 |
| Total Posts: 14257 |
|
|
| 19 Apr 2015 04:08 PM |
Oops, my bad. I included the first bit. Here it is:
local isOn = true
function on() isOn = true isOn = false for _,v in pairs(script.Parent:GetChildren()) do if string.sub(v.Name,1,3) == "lol" then v.Transparency = 1 v.CanCollide = false end end end
function off() isOn = false for _,v in pairs(script.Parent:GetChildren()) do if string.sub(v.Name,1,3) == "lol" then v.Transparency = 0 v.CanCollide = true end end end
function onClicked() if isOn == true then off() else on() end
end
script.Parent.PosA1.ClickDetector.MouseClick:connect(onClicked) script.Parent.PosA2.ClickDetector.MouseClick:connect(onClicked)
on() |
|
|
| Report Abuse |
|
|
|
| 19 Apr 2015 07:22 PM |
Script doesn't work, tell you what you accept my friend request or following me so that I can chat to you privately and I might give you the model just to fix it. But, please remove it afterwards!
Unless you can keep on trying to tweak the script a little bit. |
|
|
| Report Abuse |
|
|
NotAshley
|
  |
| Joined: 16 Jan 2014 |
| Total Posts: 14257 |
|
|
| 19 Apr 2015 07:23 PM |
local isOn = true
function on() isOn = true for _,v in pairs(script.Parent:GetChildren()) do if string.sub(v.Name,1,3) == "lol" then v.Transparency = 1 v.CanCollide = false end end end
function off() isOn = false for _,v in pairs(script.Parent:GetChildren()) do if string.sub(v.Name,1,3) == "lol" then v.Transparency = 0 v.CanCollide = true end end end
function onClicked() if isOn == true then off() else on() end
end
script.Parent.PosA1.ClickDetector.MouseClick:connect(onClicked) script.Parent.PosA2.ClickDetector.MouseClick:connect(onClicked)
on() |
|
|
| Report Abuse |
|
|
NotAshley
|
  |
| Joined: 16 Jan 2014 |
| Total Posts: 14257 |
|
|
| 19 Apr 2015 07:24 PM |
This one includes the "PosA" parts too:
local isOn = true
function on() isOn = true for _,v in pairs(script.Parent:GetChildren()) do if string.sub(v.Name,1,3) == "lol" or string.sub(v.Name,1,4) == "PosA" then v.Transparency = 1 v.CanCollide = false end end end
function off() isOn = false for _,v in pairs(script.Parent:GetChildren()) do if string.sub(v.Name,1,3) == "lol" or string.sub(v.Name,1,4) == "PosA" then v.Transparency = 0 v.CanCollide = true end end end
function onClicked() if isOn == true then off() else on() end
end
script.Parent.PosA1.ClickDetector.MouseClick:connect(onClicked) script.Parent.PosA2.ClickDetector.MouseClick:connect(onClicked)
on() |
|
|
| Report Abuse |
|
|
K7Q
|
  |
| Joined: 23 Mar 2013 |
| Total Posts: 5546 |
|
| |
|
|
| 19 Apr 2015 07:31 PM |
| I think PosA does not need to be part of the script, it's just a button - but however I have adjusted it last week which it might be affecting the problem. If I still get problems with it, then I'll have to give you the model. |
|
|
| Report Abuse |
|
|
NotAshley
|
  |
| Joined: 16 Jan 2014 |
| Total Posts: 14257 |
|
|
| 19 Apr 2015 07:32 PM |
| I only added PosA to make my script identical to the original one you posted. You modified it there, too. |
|
|
| Report Abuse |
|
|
|
| 19 Apr 2015 07:33 PM |
| Wait, if you just scripted that then the script would make it sense to the button and the bumpers. |
|
|
| Report Abuse |
|
|