NeonRiver
|
  |
| Joined: 12 Feb 2013 |
| Total Posts: 4936 |
|
| |
|
| |
|
NeonRiver
|
  |
| Joined: 12 Feb 2013 |
| Total Posts: 4936 |
|
| |
|
NeonRiver
|
  |
| Joined: 12 Feb 2013 |
| Total Posts: 4936 |
|
| |
|
|
| 10 Apr 2014 06:22 PM |
| yo man trim that tower down |
|
|
| Report Abuse |
|
|
NeonRiver
|
  |
| Joined: 12 Feb 2013 |
| Total Posts: 4936 |
|
| |
|
| |
|
NeonRiver
|
  |
| Joined: 12 Feb 2013 |
| Total Posts: 4936 |
|
| |
|
yurhomi10
|
  |
| Joined: 10 Dec 2008 |
| Total Posts: 13886 |
|
|
| 10 Apr 2014 06:26 PM |
| did you even define numplayers in the first couple lines of the script? |
|
|
| Report Abuse |
|
|
|
| 10 Apr 2014 06:26 PM |
where are the freemodels where is the source
|
|
|
| Report Abuse |
|
|
|
| 10 Apr 2014 06:26 PM |
quote:
"Suggestion: Don't ask others to debug your broken code without giving a hint what sort of problem you are having. Posting a few hundred lines of code, saying "it doesn't work", will get you ignored. Posting a dozen lines of code, saying "after line 7 I was expecting to see (something), but (something else) happened instead" is much more likely to get you a reply."
that's too long bra,tell us where the prob is,.. also:
http://wiki.roblox.com/index.php?title=Writing_Clean_Code |
|
|
| Report Abuse |
|
|
NeonRiver
|
  |
| Joined: 12 Feb 2013 |
| Total Posts: 4936 |
|
| |
|
|
| 10 Apr 2014 06:28 PM |
well,its really long,theres no indents or extra lines or comments etc and ur getting the output now? good good |
|
|
| Report Abuse |
|
|
cntkillme
|
  |
| Joined: 07 Apr 2008 |
| Total Posts: 44956 |
|
|
| 10 Apr 2014 06:28 PM |
| What is this output? And 'my script is good' is your opinion. But a fact is that it can be shortened a lot |
|
|
| Report Abuse |
|
|
NeonRiver
|
  |
| Joined: 12 Feb 2013 |
| Total Posts: 4936 |
|
| |
|
|
| 10 Apr 2014 06:30 PM |
ok,first thing creating several hints in VERY inneficient,why not use a table to store the texts,and loop thru it and set hint1.Text to it
also
while true do gonna lag ur game bro
while wait() do--doesn't freeze |
|
|
| Report Abuse |
|
|
|
| 10 Apr 2014 06:31 PM |
like txts = {"hi","by","sup sup"} h = Instance.new("Hint",Workspace) for I,v in pairs(txts) do h.Text = v wait(timeHere) end |
|
|
| Report Abuse |
|
|
cntkillme
|
  |
| Joined: 07 Apr 2008 |
| Total Posts: 44956 |
|
|
| 10 Apr 2014 06:31 PM |
Or just do:
while true do if game.Players.NumPlayers>1 then --etc code else game.Players.PlayerAdded:wait() end |
|
|
| Report Abuse |
|
|
|
| 10 Apr 2014 06:32 PM |
@cnt genius :P but that's still rather inifeccient,why not just while wait() do |
|
|
| Report Abuse |
|
|
cntkillme
|
  |
| Joined: 07 Apr 2008 |
| Total Posts: 44956 |
|
|
| 10 Apr 2014 06:33 PM |
| Actually, it's like 100x more efficient then yours, since it will not run the loop UNTIL someone joins when the player count is 0 while yours is running always at ~s/30 |
|
|
| Report Abuse |
|
|
cntkillme
|
  |
| Joined: 07 Apr 2008 |
| Total Posts: 44956 |
|
|
| 10 Apr 2014 06:33 PM |
| Won't run the loop more than once* |
|
|
| Report Abuse |
|
|
yurhomi10
|
  |
| Joined: 10 Dec 2008 |
| Total Posts: 13886 |
|
| |
|
|
| 10 Apr 2014 06:46 PM |
oh,thats right >_< but still,that makes it longer(the script itself) |
|
|
| Report Abuse |
|
|
cntkillme
|
  |
| Joined: 07 Apr 2008 |
| Total Posts: 44956 |
|
|
| 10 Apr 2014 06:49 PM |
efficiency > size
Plus it's only 2 lines |
|
|
| Report Abuse |
|
|
|
| 10 Apr 2014 06:50 PM |
still,still.. his script WAS already long :P
but yeah,i have to admit,itll loop it once,then wait until player joins |
|
|
| Report Abuse |
|
|